This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
Add support for authentication API v3 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix for intelsdi-x#21 Signed-off-by: Patryk Matyjasek <[email protected]>
PatrykMatyjasek
force-pushed
the
pm-auth-api-v3-support
branch
from
68b1be7 to
d2b7454
Compare
ghost
approved these changes
Apr 4, 2017
| @@ -8,6 +8,8 @@ | |||
| "openstack_user": "admin", | |||
| "openstack_pass": "admin", | |||
| "openstack_tenant": "admin", | |||
| "openstack_domain_id": "", | |||
There was a problem hiding this comment.
When using API v3 you need to specify one of the openstack_domain_id or openstack_domain_name. If the user specifies both of them they get an error that one can specify only one of them.
However both of them need to specified in global config as due to usage of function config.GetConfigItem() all the fields in config are mandatory.
It may be a bit confusing for the user. So:
- we should add note to documentation that all the config options are mandatory, and one of options
openstack_domain_idoropenstack_domain_nameneeds to be set to an empty string when using v3. - open an issue to refactor getting config items
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for authentication API v3
Signed-off-by: Patryk Matyjasek [email protected]