This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Fix a bug in deflate_medium where it didn't take into account the current window size #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e current window size.
|
Good catch. Thanks! |
jtkukunas
added a commit
that referenced
this pull request
Apr 15, 2022
Fix a bug in deflate_medium where it didn't take into account the current window size
jtkukunas
added a commit
that referenced
this pull request
Apr 25, 2022
Fix a bug in deflate_medium where it didn't take into account the current window size
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During tests for websocket compression in https://github.com/dotnet/runtime we found what we think is a bug. Sometimes the deflate produced payload, which couldn't be inflated later (see dotnet/runtime#50235 for examples).
After trying to debug what might be happening I noticed that deflate_medium has a constant defined:
This seems absolutely fine when the deflate is being used with 15 window bits, but seems wrong with any other window size.
The error went away after replacing this with
MAX_DIST(s)which is defined as:A minimal c++ repro can be found here dotnet/runtime#50235 (comment). Let me know if you need more information and I will be happy to provide it.