Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Common] Fix convert bugs when size < 16. #80

Merged
merged 3 commits into from
Nov 24, 2023
Merged

[Common] Fix convert bugs when size < 16. #80

merged 3 commits into from
Nov 24, 2023

Conversation

changqi1
Copy link
Contributor

No description provided.

@changqi1 changqi1 requested a review from pujiang2018 November 24, 2023 12:41
@pujiang2018
Copy link
Contributor

Another method is to change
for (int i = 0; i < size; i += kStep)
to:
for (int i = 0; i + (kStep - 1) < size; i += kStep)

Just one line change, :)
Of course, yours also OK.

@pujiang2018 pujiang2018 merged commit 68dccf2 into main Nov 24, 2023
1 check passed
@Duyi-Wang Duyi-Wang deleted the bugfix/common/types branch May 13, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pujiang2018 pujiang2018 pujiang2018 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@changqi1 @pujiang2018 @abenmao