[API][CPP] Add overloaded func of model.config. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Duyi-Wang <[email protected]>
changqi1
reviewed
Nov 14, 2023
| @@ -33,6 +33,8 @@ class Model { | |||
| bool doEarlyStopping_ = false, int eosTokenId_ = -1, int padTokenId_ = -1, bool doSample_ = false, | |||
| float temperature_ = 1.0, int topK_ = 50, float topP_ = 1.0); | |||
|
|
|||
| void config(SearcherConfig &config_); | |||
There was a problem hiding this comment.
When you have added the config api, but you didn't use it?
There was a problem hiding this comment.
This is necessary for C++ API since it's annoying that all parameters are passed when just the last one is changed. There are two ways now, I just choose another way in the example.
changqi1
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.