-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI, enhancement] enable external oneDAL builds in build-and-test-lnx.yml Azure Pipelines #2125
base: main
Are you sure you want to change the base?
[CI, enhancement] enable external oneDAL builds in build-and-test-lnx.yml Azure Pipelines #2125
Conversation
@@ -27,47 +28,73 @@ steps: | |||
conda config --add channels conda-forge | |||
conda config --set channel_priority strict | |||
conda update -y -q conda | |||
conda create -q -y -n CB -c conda-forge python=$(PYTHON_VERSION) dal-devel mpich pyyaml "dpcpp-cpp-rt=2024.2.0" | |||
conda create -q -y -n CB -c conda-forge python=$(PYTHON_VERSION) mpich pyyaml "dpcpp-cpp-rt=2024.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: would this switch all of these jobs to the external builds? I think it'd be quite useful to leave some with the stable release too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good question and suggestion. Why do we stop using stable version for building and testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will switch to external builds only if a DALROOT is specified, and example using it is here: oneapi-src/oneDAL#2950 which is the immediate use case. The question remains the same as when GitHub actions CI was introduced, do we eventually want to move toward using versions of oneDAL main branch rather than release branches?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@icfaust I think it would be good to get @homksei @Alexsandruss @napetrov and @syakov-intel ’s opinions on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samir-nasibli Just as a note, there is a precedence within the conda-recipe for DPCPPROOT set outside of the conda-recipe: https://github.com/intel/scikit-learn-intelex/blob/main/conda-recipe/build.sh#L38
This work simply continues on that precedent.
Secondly, the core flow using stable versions for building and testing on azure pipelines CI is not changed. Dal-devel and oneapi components are still acquired from conda in azure pipelines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @icfaust for the clarification. For me resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Depending on @david-cortes-intel @ethanglaser @Alexsandruss reviews
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Just a comment that perhaps once this PR gets merged: #2170
There might be an easier way to avoid these .sh scripts with external builds.
Description
Try to add ability to externally specify a oneDAL build into this template. This is the beginning of a multi-step process to allow for the use of nightly oneDAL builds.
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance