Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

https://github.com/intel/rohd-hcl/issues/48 #49

Merged
merged 1 commit into from
Sep 29, 2023
Merged

https://github.com/intel/rohd-hcl/issues/48 #49

merged 1 commit into from
Sep 29, 2023

Conversation

chaparalas
Copy link
Contributor

Description & Motivation


Remove reset on the rd-data out path.

Related Issue(s)

Testing

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

NO

mkorbel1
mkorbel1 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mkorbel1 mkorbel1 linked an issue Sep 29, 2023 that may be closed by this pull request
RegisterFile is incorrectly using reset in Combinational #48
Closed
@mkorbel1 mkorbel1 merged commit 861c4ad into intel:main Sep 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkorbel1 mkorbel1 mkorbel1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RegisterFile is incorrectly using reset in Combinational
2 participants
@chaparalas @mkorbel1