Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
Adds an optional Logic signal to integer multiplier to configure for signed or unsigned operands at runtime. This uses
the 1-bit wider unsigned footprint of the PartialProductArray, as well as modifies the sign extension. The signed configuration is disabled when this signal is configured.
Related Issue(s)
Issue 121: Sign agnostic multiplier
Testing
Random test added that generates signed and unsigned operands for multiplication.
Backwards-compatibility
No. If you use a signed configuration flag, you cannot use this feature, you must disable that configuration and pass in a Logic during construction which allows runtime control. Otherwise, you can continue to hard-configure signed or unsigned operations.
Documentation
Yes. The new operand is documented in the source and a checkbox added to the configurator.