Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift Register Updates #105

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Shift Register Updates #105

merged 3 commits into from
Oct 11, 2024

Conversation

robtorx
Copy link
Contributor

@robtorx robtorx commented Oct 10, 2024

Description & Motivation

The shift register component was changed to include functionality for asynchronous reset and for individual stages of the shift register to have different reset values.
Motivation stems from a need for this functionality in implementing SPI for ROHD.

Related Issue(s)

N/A

Testing

More tests were added to the existing shift register tests, testing lists of reset values and async reset.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

Component documentation was updated

Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

test/shift_register_test.dart Outdated Show resolved Hide resolved
@robtorx robtorx requested a review from mkorbel1 October 10, 2024 20:08
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@mkorbel1 mkorbel1 merged commit a244a54 into intel:main Oct 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants