[WIP] add float conversion for arbitrary mantissa width and exponent width #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkorbel1
reviewed
Oct 9, 2024
| exponent.toInt() == | ||
| computeMaxExponent(exponent.width) + computeBias(exponent.width) + 1; | ||
|
|
||
| bool isNaN() => isExponentAllOnes() && mantissa.toInt() == 0; |
There was a problem hiding this comment.
instead of converting to int, check if the value is zero using isZero so that you can support mantissas >64 bits
| /// are counted from the most significant bit (bit width-1) towards | ||
| /// the least significant bit. | ||
| /// | ||
| /// For example, the binary number 0b00101010 would return 3, as |
| /// | ||
| /// For example, the binary number 0b00101010 would return 3, as | ||
| /// there are 3 leading zeroes. | ||
| int countLeadingZeroes(LogicValue value) { |
There was a problem hiding this comment.
if this is a good utility in a generic sense, maybe it should be an extension on LogicValue or even added to ROHD itself. If it's mostly just useful for this math stuff, let's keep it private (start name with _) so that it's not exposed as a public API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.