Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake options prefix #794

Closed
artiomn opened this issue Jul 17, 2024 · 0 comments
Closed

CMake options prefix #794

artiomn opened this issue Jul 17, 2024 · 0 comments

Comments

@artiomn
Copy link
Contributor

artiomn commented Jul 17, 2024

Probably is not a bad idea to add prefix to the options. I.e. INTEL_PCM_.

After this, the options will be named not like NO_ASAN, but like INTEL_PCM_NO_ASAN.

Why:

  • Visually "highlight" PCM options.
  • Remove potential intersection with other projects. I.e., somebody using add_subdirectory and has an option with a name similar to PCM. He doesn't want to affect the PCM option, but he does and needs to make workarounds.
  • Remove potential intersection with special CMake variables.

How:

  • Add new options with prefixes.
  • Add stub for old option names, which will print deprecation warning.
  • Remove old names in some future version.

P.S.: Probably CMake option command will be more natural and convenient to use than "ordinary variables".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants