Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check version; fail if pre-2024.2 #149

Merged
merged 5 commits into from
Oct 14, 2024
Merged

Check version; fail if pre-2024.2 #149

merged 5 commits into from
Oct 14, 2024

Commits on Oct 10, 2024

  1. Check version; fail if pre-2024.2 

    In intel#143, we discovered that upstream OpenVINO had changed the
`ov_element_type_e` enum in a backwards-incompatible way. This means
that a mismatch between the Rust bindings (based on the C headers) and
the shared library will result in tensors being created with the wrong
type (e.g., `U64` instead of `U8`). To avoid this situation, this change
reads the OpenVINO library version at runtime (e.g., every time a `Core`
is created) and fails with an error if the version is older than 2024.2,
when the breaking change was introduced.

The effect of merging this change would be that newer bindings will fail
when used with older libraries, which could be problematic for users.
Users could always use an older version of the library (e.g., `v0.7.*`)
instead. And the alternative, letting users create tensors of the wrong
type, seems like it would open up the door to a slew of reported issues.
    @abrown
    abrown committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f331bae View commit details
    Browse the repository at this point in the history

  2. Add documentation to helper functions

    @abrown
    abrown committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    248b785 View commit details
    Browse the repository at this point in the history

  3. Update CI versions: library + OS 

    This updates CI to test only the latest three OpenVINO versions, since
older versions will no longer be accessible due to the new "breaking
change version check." It also updates the OS version of the GitHub
runner for good measure.
    @abrown
    abrown committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f7eeb50 View commit details
    Browse the repository at this point in the history

  4. ci: specify ubuntu-24.04

    @abrown
    abrown committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ff5a691 View commit details
    Browse the repository at this point in the history

  5. ci: roll back OS version 

    OpenVINO has not published packages for `ubuntu-24.04`.
    @abrown
    abrown committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    4dce225 View commit details
    Browse the repository at this point in the history