Enable testing on newer GCC releases and clean up warnings on them #107
Conversation
Also, ignore an auto-generated file made by newer automake releases. Enable all warnings for build. Move to non-deprecated checkout version.
Added missing dependencies
The current macro, which uses strncpy() and then forces a valid termination, triggers warnings under GCC 10. It can also cause an out-of-bounds write if size is 0. strlcpy() was added in glibc 2.38 (July 2023).
Macro would previously trigger an out-of-bound write if passed a size of zero. Also, the size was not protected against a possible operator precedence issue.
GCC 10+ is producing a warning that strncpy() may truncate without valid nul termination, however, the code is easily checked that nul termination is added immediately afterwards.
penguin359
changed the title
|
Hmm, I guess since I am a contributor outside the project modifying the GitHub workflow, it won't automatically run the workflow without approval. I suppose that makes sense, but I was expecting it would just run. In any case, is pretty quick to run the checks once approved. |
|
After reviewing the build logs from the https://github.com/penguin359/openlldp/actions/runs/10337712563/job/28614883097#step:8:153 |
|
Applied, thanks! |
In my earlier PR for enabling build testing automation, I stopped at GCC 9.x because newer releases were triggering warnings and would therefore fail the build since
-Werrorwas in effect. This PR adds in those versions and fixes all warnings up through GCC 14.x.The main issue is the call to
strncpy()in theSTRNCPY_TERMINATEDmacro triggers GCC's concerns over a possible non-terminated string even though a quick analysis will show that it is indeed terminated. This warning is present up through at least GCC 14.x. I initially tried to replace the macro with a call tostrlcpy()which is a safe version ofstrncpy(), but that is too new for many systems so I have the warning silenced inside the macro on newer GCC versions. There are no more warnings on any version of GCC tested now.strlcpy()when presentstrlcpy()is not availablestrncpy()