Add framework-agnostic tests for common components #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yiliu30 <[email protected]>
yiliu30
changed the title
|
Hi @chensuyue, as we discussed offline, I've added some framework-agnostic tests to this PR, and more are WIP. I hope it helps you update the CI script accordingly. |
ftian1
reviewed
Jan 26, 2024
ftian1
reviewed
Jan 26, 2024
Signed-off-by: chensuyue <[email protected]>
chensuyue
reviewed
Jan 28, 2024
Signed-off-by: yiliu30 <[email protected]>
Signed-off-by: yiliu30 <[email protected]>
chensuyue
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
feature: Implement #1445 (comment)
API changed or not: None
Description
Refer to #1445 (comment) for details.
Resolve below TODOs to trigger the test
register_supported_configsfor all registered configs.How has this PR been tested?
Pre-CI
Dependency Change?
None