Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][CUDA][libclc] Implement nextafter for sycl::half in generic/. #4939

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

hdelan
Copy link
Contributor

@hdelan hdelan commented Nov 11, 2021

sycl::nextafter(half,half) was defaulting to sycl::nextafter(float,float) which does not return the next half.

Software implementation written in libclc/generic and #included into ptx-nvidiacl.

@hdelan hdelan requested a review from bader as a code owner November 11, 2021 12:56
@bader bader changed the title [SYCL][CUDA][libclc] Implementing nextafter for sycl::half in generic/. [SYCL][CUDA][libclc] Implement nextafter for sycl::half in generic/. Nov 17, 2021
@bader
Copy link
Contributor

bader commented Nov 18, 2021

@alexbatashev, pre-commit for this PR failed with

sycl/tools/pi-trace/pi_trace.cpp
sycl/tools/pi-trace/pi_trace.cpp:32:1: error: ‘XPTI_CALLBACK_API’ does not name a type; did you mean ‘CL_CALLBACK’?
 XPTI_CALLBACK_API void tpCallback(uint16_t trace_type,
 ^~~~~~~~~~~~~~~~~
 CL_CALLBACK
sycl/tools/pi-trace/pi_trace.cpp:40:1: error: ‘XPTI_CALLBACK_API’ does not name a type; did you mean ‘CL_CALLBACK’?
 XPTI_CALLBACK_API void xptiTraceInit(unsigned int /*major_version*/,
 ^~~~~~~~~~~~~~~~~
 CL_CALLBACK
sycl/tools/pi-trace/pi_trace.cpp:66:1: error: ‘XPTI_CALLBACK_API’ does not name a type; did you mean ‘CL_CALLBACK’?
 XPTI_CALLBACK_API void xptiTraceFinish(const char * /*stream_name*/) {
 ^~~~~~~~~~~~~~~~~
 CL_CALLBACK
sycl/tools/pi-trace/pi_trace.cpp:70:1: error: ‘XPTI_CALLBACK_API’ does not name a type; did you mean ‘CL_CALLBACK’?
 XPTI_CALLBACK_API void tpCallback(uint16_t TraceType,
 ^~~~~~~~~~~~~~~~~
 CL_CALLBACK
sycl/tools/pi-trace/pi_trace.cpp:25:16: error: ‘GStreamID’ defined but not used [-Werror=unused-variable]
 static uint8_t GStreamID = 0;
                ^~~~~~~~~
cc1plus: all warnings being treated as errors

I have no idea why this issue appears for libclc changes. Could you take a look, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda CUDA back-end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants