Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Fix sub-group mask for smaller SG sizes #4916

Merged
merged 5 commits into from
Nov 18, 2021

Conversation

vladimirlaz
Copy link
Contributor

Fix accessing sub-group mask when sub-group size is less than 32. Make sure that false is returned for positions that are more than sub-group size.

Update the test to check this case.

Fix accessing sub-group mask when sub-group size is less that 32.
@vladimirlaz vladimirlaz requested a review from a team as a code owner November 8, 2021 18:16
@vladimirlaz vladimirlaz marked this pull request as draft November 9, 2021 09:58
@vladimirlaz vladimirlaz marked this pull request as ready for review November 16, 2021 05:44
@vladimirlaz
Copy link
Contributor Author

@steffenlarsen could you please have a look?

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for missing this one. LGTM!

@dm-vodopyanov dm-vodopyanov merged commit c855fd1 into intel:sycl Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants