Make Intel attributes consistent with clang attributes. #3022
Conversation
Clang allows attributes to be specified via a special pragma named `#pragma clang attribute` and many of the Intel-specified attributes were opting out of this support for no real reason. This changes allows Intel attributes to be specified via this pragma, similar to how almost all other Clang attributes are.
|
This addresses #2910 |
Oh jeez. Go figure that I'd use a different word than what's on the supported list. :-D Thanks for pointing this out! |
Sorry for the duplicated effort! And you're right -- I hadn't noticed that because my local build has a ton of failures that are unrelated to the patch (I think they have to do with separator differences between a normal Windows shell and our shell). I'll update the test and push a change. |
No problem! Thanks! |
Note, that it works only if these words are used in PR description or commit message and it doesn't work for PR comments. Anyway, you can always link/close issues manually - this feature automates a few clicks only. |
* sycl: (378 commits) [sycl-post-link][NFC] Extracted the code into a subroutine (intel#3042) [SYCL][NFC] Remove commented out code (intel#3029) [CODEOWNERS] Fix ownership of DPC++ tools tests (intel#3047) [SYCL][NFC] Make tests insensitive to dso_local (intel#3037) [SYCL] Fix acquiring a mutex in _pi_context::finalize (intel#3001) [SYCL] Fix various compilation warnings in plugins (intel#2979) [SYCL][ESIMD] Add simd class conversion ctor and operator (intel#3028) [sycl-post-link][NFC] Use range-based for loop. (intel#3033) [SYCL][NFC] Fix warning in self-build (intel#3023) [NFC] Fix sycl-post-link tests to avoid potential race (intel#3031) [SYCL][CUDA] Add missing barrier to collectives (intel#2990) [SYCL] Make Intel attributes consistent with clang attributes. (intel#3022) [SYCL] Bump SYCL minor version (intel#3026) [SYCL][Doc] Added requirement on reference to test PR in commit message (intel#3010) [SYCL] Put constant initializer list data in non-generic addr space. (intel#3005) [SYCL][L0] Fix memory leak in PiDeviceCache and ZeCommandList (intel#2974) [SYCL] Fix detection of free function calls (intel#3003) [SYCL][NFC] Clean up the builder_dir argument description (intel#3021) [SYCL][ESIMD] Fix LowerESIMD crash on a scalar fptoui LLVM instruction (intel#2699) [NFC] Remove redundant call to getMainExecutable() (intel#3018) ...
Clang allows attributes to be specified via a special pragma named
#pragma clang attributeand many of the Intel-specified attributeswere opting out of this support for no real reason.
This changes allows Intel attributes to be specified via this pragma,
similar to how almost all other Clang attributes are.
Closes #2910.