[SYCL] Remove wrapper headers #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even when compiling for the device, code meant only for host execution must be semantically analyzable. Existing wrapper headers were initially created to resolve this problem. But now -aux-triple is used to pass target triple of opposite side of compilation. Clang knows target triple for both sides of compilation so that preprocessor macros and target builtins from both sides are available. That is why there is no need in existing wrapper headers with stub definitions since they break compilation for cases when standard headers are included. Approach with -aux-triple is not complete solution. Host headers might provide definitions relying on host inline asm, intrinsics, using types not lowerable in device code. So we will need to provide a solution to overload some definitions for the device or to define only some macro for host headers. This will be resolved in other commits. Signed-off-by: Artur Gainullin <[email protected]>
keryell
approved these changes
Jun 19, 2019
bader
approved these changes
Jun 19, 2019
This was referenced Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even when compiling for the device, code meant only for host execution
must be semantically analyzable. Existing wrapper headers were initially
created to resolve this problem. But now -aux-triple is used to pass
target triple of opposite side of compilation. Clang knows target triple
for both sides of compilation so that preprocessor macros and target
builtins from both sides are available. That is why there is no need in
existing wrapper headers with stub definitions since they break
compilation for cases when standard headers are included.
Approach with -aux-triple is not complete solution. Host headers might
provide definitions relying on host inline asm, intrinsics, using types
not lowerable in device code. So we will need to provide a solution to
overload some definitions for the device or to define only some macro
for host headers. This will be resolved in other commits.
Signed-off-by: Artur Gainullin [email protected]