[SYCL] Change some check_device_code tests to use SYCL_EXTERNAL #13899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of submitting to a queue
sergey-semenov
changed the title
sergey-semenov
approved these changes
May 24, 2024
| @@ -13,12 +13,9 @@ const intel::fpga_datapath<int[10]> empty{}; | |||
| // CHECK: %[[datapath:.*]] = type { [10 x i32] } | |||
| // CHECK: {{.*}}empty = internal addrspace(1) constant %[[datapath]] zeroinitializer, align 4, !spirv.Decorations ![[empty_md:[0-9]*]] | |||
|
|
|||
| int main() { | |||
| queue Q; | |||
| SYCL_EXTERNAL void fpga_datapath_global() { | |||
There was a problem hiding this comment.
JFYI: I think f should have been made an argument for the change to be a no-op (it was previously a kernel argument because of the lambda capture), but it likely doesn't matter here.
|
|
||
| Q.single_task([=]() { volatile int ReadVal = empty[f]; }); | ||
| return 0; | ||
| volatile int ReadVal = empty[f]; |
There was a problem hiding this comment.
I think the purpose of this volatile int was to prevent the optimizer from removing everything. In the new approach the idiomatic way would be to just return that int value, e.g.
SYCL_EXTERNAL auto /* or int, maybe */ fpga_datapath_global(int f) { return emtpy[f]; }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed some of the simpler test cases to use SYCL_EXTERNAL functions instead of submitting to a queue.