[SYCL] fix opaque pointer issue in compileTimeProperty alignment #10748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LU-JOHN
reviewed
Aug 18, 2023
| AnnotStrArgGV = dyn_cast<GlobalVariable>(C); | ||
| if (IntrAnnotStringArg->getType()->isOpaquePointerTy()) | ||
| AnnotStrArgGV = dyn_cast<GlobalVariable>(IntrAnnotStringArg); | ||
| else if (auto *GEP = dyn_cast<GEPOperator>(IntrAnnotStringArg)) |
There was a problem hiding this comment.
The handling for this case (which does not seem to be related to opaque pointers) has changed. What's the rationale for this change?
There was a problem hiding this comment.
This is for the opaque pointer. If the arg on ptr.annotation is an opaque pointer we do things differently
|
@intel/llvm-gatekeepers Can this be merged? It has a bug fix related to opaque pointers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update compileTimeProperties pass to check opaque pointers