Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signature verification error in sgx_report_attestation_status and a make dependency problem #359

Merged
merged 2 commits into from
Jan 10, 2019

Conversation

dingelish
Copy link
Contributor

@dingelish dingelish commented Dec 31, 2018

4baa19d
In 2.4.0, sgx_report_attestation_status always returns SGX_ERROR_INVALID_PARAMETER due to oal_map_result returns AESM_PLATFORM_INFO_BLOB_INVALID_SIG. The problem is caused by a change in u_certificate_provisioning.cpp, removing essential endian conversion. This commit aims at reverting this change and making sgx_report_attestation_status works again.

One test case on my testbed, which accepted by 2.3.1 but denied by 2.4.0: 1502006500000800000202020401800000000000000000000007000006000000020000000000000B0D292FE7F0F37C075567E227A454318D29A3E94F035693794FADECD6C31606DE989858BF7FB718A096B52A90EFCD50270C9A0A2F4500CFAC159DD44EAA2C014179

This case is accepted by aesm_service with the given patch.

dd54bf1
make -j the entire SDK always results in an error message about cannot find utility from sgx_random_buffers.h when compiling trts_ecall.cpp. I found that this is caused by doing make in sdk/trts/linux before sdk/trts. This patch fixes the problem by an additional dependency.

Signed-off-by: Yu Ding [email protected]

In 2.4.0, sgx_report_attestation_status always returns SGX_ERROR_INVALID_PARAMETER due to oal_map_result returns AESM_PLATFORM_INFO_BLOB_INVALID_SIG. The problem is caused by a change in u_certificate_provisioning.cpp, removing essential endian conversion. This commit aims at reverting this change and making sgx_report_attestation_status works again.

One test case on my testbed: 1502006500000800000202020401800000000000000000000007000006000000020000000000000B0D292FE7F0F37C075567E227A454318D29A3E94F035693794FADECD6C31606DE989858BF7FB718A096B52A90EFCD50270C9A0A2F4500CFAC159DD44EAA2C014179

Signed-off-by: Yu Ding <[email protected]>
Signed-off-by: Yu Ding <[email protected]>
@dingelish dingelish changed the title Fix signature verification error in sgx_report_attestation_status Fix signature verification error in sgx_report_attestation_status and a make dependency problem Dec 31, 2018
@dingelish
Copy link
Contributor Author

Hi there, is this a valid patch or not? If not, what is the better way to resolve the signature verification error? Thanks!

@llly
Copy link
Contributor

llly commented Jan 9, 2019

This is a bug and your patch works. We are applying validations before merge your PR.

@dingelish
Copy link
Contributor Author

Thanks @llly !

@llly llly merged commit a85fbe9 into intel:master Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants