Support DKMS

[michwill]

Standard "make install" fails in Ubuntu 16.04 because kernel there requires signed modules.

DKMS cares about all of that.

[ghost]

Use a proper format with short summary line and a long description. The commit message is also missing Signed-off-by tag. You should describe in the commit message why the change is needed and how it manages to get it done.

[mitar]

I simplified it a bit.

dkms.conf

PACKAGE_NAME="isgx"
PACKAGE_VERSION="0.10"
MAKE="'make'"
CLEAN="'make' clean"
BUILT_MODULE_NAME=isgx
REMAKE_INITRD=yes
DEST_MODULE_LOCATION=/updates
AUTOINSTALL="yes"

dkms-install.sh

#!/bin/bash -e

VERSION="0.10"

if ! dkms status -m isgx -v "$VERSION" | grep -q 'added\|built\|installed' ; then
  dkms add -m isgx -v "$VERSION"
fi

dkms build -m isgx -v "$VERSION" --verbose
dkms install -m isgx -v "$VERSION"

If I clone this repository into /usr/src/isgx-0.10 and copy these two files in, I can run the install script and it works well on Ubuntu 16.04.

[mitar]

The fact that make is inside ' is so that KERNELRELEASE is not passed through.

[donporter]

+1 on this PR. Being able to automatically update the isgx driver after a kernel upgrade would be awfully nice. Is there something that can be done to help get this out the door?

[haitaohuang]

please update the patches with proper sign-off and comments format as mentioned above @jsakkine-intel

[donporter]

I"m happy to add a comment about what problem this code solves - that is easy - it automatically rebuilds the driver after a kernel upgrade. This is super userful, at least for organizations that stay on top of security advisories.

But, not being the author, I am not sure I am in a position to sign off on this. Can anyone other than @michwill sign off on this patch?

[michwill]

@donporter feel free to do whatever you like with the patch :-)