update data type #17
update data type #17
Conversation
| @@ -83,4 +83,7 @@ typedef enum { | |||
| className(const className&); \ | |||
| className & operator=(const className&); \ | |||
|
|
|||
| #define N_ELEMENTS(array) \ | |||
There was a problem hiding this comment.
not good, codecparsers/jpegparser.c is not compile-able. Since it's not include vaapitypes.h.
vaapitypes.h is only for vaapi related things. we'd better not make codecparser depends on it.
There was a problem hiding this comment.
In terms of the issue of the macro N_ELEMENTS(array) , I asked Halley, he told me I can add it in vaapitypes.h file, if not better solution.
If you have more better solution, welcome to your suggestion.
From: Xu Guangxin [mailto:[email protected]]
Sent: Thursday, May 08, 2014 9:55 AM
To: 01org/libyami
Cc: Xiong, Pin
Subject: Re: [libyami] update data type (#17)
In common/vaapitypes.h:
@@ -83,4 +83,7 @@ typedef enum {
className(const className&); \ className & operator=(const className&); \+#define N_ELEMENTS(array) \
not good, codecparsers/jpegparser.c is not compile-able. Since it's not include vaapitypes.h.
vaapitypes.h is only for vaapi related things. we'd better not make codecparser depends on it.
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/17/files#r12412865.
There was a problem hiding this comment.
This change will make jpegparser.c not compile able. Because you did not include vaapitypes.h in Jpegparser.c, it can’t find N_ELEMENTS definition.
If you can pass compile in your machine, maybe you use an old header file. You did not clear the file in your install directory.
How about create cutils.h.
Move all c related utils to it.
From: pinxiong [mailto:[email protected]]
Sent: Thursday, May 8, 2014 10:30 AM
To: 01org/libyami
Cc: Xu, Guangxin
Subject: Re: [libyami] update data type (#17)
In common/vaapitypes.h:
@@ -83,4 +83,7 @@ typedef enum {
className(const className&); \ className & operator=(const className&); \+#define N_ELEMENTS(array)
In terms of the issue of the macro N_ELEMENTS(array) , I asked Halley, he told me I can add it in vaapitypes.h file, if not better solution. If you have more better solution, welcome to your suggestion. From: Xu Guangxin [mailto:[email protected]] Sent: Thursday, May 08, 2014 9:55 AM To: 01org/libyami Cc: Xiong, Pin Subject: Re: [libyami] update data type (#17#17) In common/vaapitypes.h:
@@ -83,4 +83,7 @@ typedef enum { className(const className&); \ className & operator=(const className&); \ +#define N_ELEMENTS(array)
not good, codecparsers/jpegparser.c is not compile-able. Since it's not include vaapitypes.h. vaapitypes.h is only for vaapi related things. we'd better not make codecparser depends on it. — Reply to this email directly or view it on GitHubhttps://github.com//pull/17/files#r12412865.
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/17/files#r12413435.
There was a problem hiding this comment.
agree to add cutils.h
we miss a common header for yami.
'uint8' to 'uint8_t', 'int8' to 'int8_t', 'uint16' to 'uint16_t', 'int16' to 'int16_t', 'uint32' to 'uint32_t', 'int32' to 'int32_t', 'uint64' to 'uint64_t', 'int64' to 'int64_t', 'boolean' to 'bool', 'BOOL' to 'bool', 'TRUE' to 'true', 'FALSE' to 'false' 2.Create a directory 'vaapi', which contains all files related vaapi,including 'vaapibuffer.cpp','vaapibuffer.h', 'vaapiimage.cpp', 'vaapiimage.h', 'vaapiptrs.h', 'vaapisurface.h', 'vaapiutils.cpp', 'vaapiutils.h'. All of those files mentioned above are belong to the directory 'common' before. 3.Update Makefile.am, Configure.ac 4.Add the file 'common_def.h' into the directory 'common', which includes the define of 'TREU', 'FALSE' and the macro 'N_ELEMENTS(array)' 5.Remove the macro 'N_ELEMENTS(array)' in the files 'vaapisurface.cpp' and 'vaapitypes.h', instead of adding the reference of '#include <common_def>'
|
the pull request has been changed to #23 |
No description provided.