ClearLinux Support #2

electrocucaracha · 2019-04-06T00:31:00Z

This change is an effort to add support of ClearLinux Distribution.

vagrant/ClearLinux.yml

vagrant/krd-vars.yml

mythi · 2019-04-08T10:49:42Z

vagrant/_commons.sh

+            ;;
+        esac
+        #sudo git clone https://github.com/kubernetes-sigs/kubespray $kubespray_folder
+        sudo git clone https://github.com/electrocucaracha/kubespray $kubespray_folder


my expectation is when running on Clear Linux we use k8s what Clear linux ships in cloud-native-basic bundle. The bundle provides easy-to-use installation scripts in /usr/share/clr-k8s-examples

AFAIK this PR does that https://github.com/kubernetes-sigs/kubespray/pull/3855/files

Does it work for you? A quick look tells me it installs containers-basic (and not cloud-native-basic)

I did some checking and apparently kubespray always uses the upstream binaries and not what the OS provides (for cri-o, kubeadm/kubelet). It also does not give you kata-containers.

We can do those changes after Kubernetes is deployed. Eventually we can propose those changes to the Kubespray community

We can do those changes after Kubernetes is deployed.

I don't follow what changes? My proposal is for Clear install we use cloud-native-basic and the setup scripts it provides.

vagrant/installer.sh

vagrant/sample_plugin.sh

vagrant/prechecks.sh

vagrant/postchecks_qat_plugin.sh

ipuustin · 2019-04-09T08:22:59Z

vagrant/postchecks_qat_driver.sh

@@ -16,10 +16,10 @@ echo "QAT driver validation"

 # Driver validation
 supported_dev="c6xx dh895xcc"
-qat_svc=$(sudo service qat_service status | grep "There is .* QAT acceleration device(s) in the system:")
+qat_svc=$(sudo systemctl status qat_service | grep "There is .* QAT acceleration device(s) in the system:")


It seems that adf_ctl status return value is zero if acceleration devices are present in the system. If you can verify this, there is no need to parse the (fragile) service logging output.

It returns zero if the command was executed properly:

[vagrant@localhost ~]$ sudo /usr/local/bin/adf_ctl status Checking status of all devices. There is 0 QAT acceleration device(s) in the system: [vagrant@localhost ~]$ echo $? 0

Did you try the negative case too? If both work then this might be a cleaner way to implement the check.

vagrant/installer.sh

ipuustin · 2019-05-02T10:47:18Z

I see you force pushed the branch a few times. Please comment if the PR is ready for another review round or if there are still unresolved issues left.

electrocucaracha · 2019-05-02T14:39:24Z

I see you force pushed the branch a few times. Please comment if the PR is ready for another review round or if there are still unresolved issues left.

@ipuustin it's failing when Kata is selected as container runtime. I'll let you know when this can be ready to be reviewed

electrocucaracha · 2019-05-03T18:04:33Z

@ipuustin @mythi I have completed the support for ClearLinux. I need to work on the instructions to don't use the pre-built Kata images, but in the meantime could you review this patch? I created the test.sh script for testing all the possible combinations

vagrant/krd-vars.yml

electrocucaracha · 2019-06-06T01:24:40Z

@mythi and @ipuustin I tried to test every single commit that I made and I tried to isolate the changes to make clear their purpose but the latest version has evolved thanks to your comments, I can try to figure out how to squash some of them as long as this is the final version.

mythi · 2019-06-07T19:49:43Z

I don't think I have any more comments. podman still needs to be added but ready to take it later.

@electrocucaracha can you try out squashing some of the commits?

electrocucaracha · 2019-06-11T17:25:54Z

I don't think I have any more comments. podman still needs to be added but ready to take it later.

@electrocucaracha can you try out squashing some of the commits?

@mythi I created two branches in my repo, the backup contains the original version with 43 commits ahead of intel:master and the new refactored clearlinux branch with 32 commits ahead. I'm finalizing the tests and I'll let you know when I'm ready.

mythi · 2019-06-11T18:08:48Z

@electrocucaracha thanks!

mythi · 2019-06-12T09:59:00Z

@electrocucaracha I checked the latest changes and I'm still not happy with the commits. There are several "intermediate stages" still:

enable cri-o, fix cri-o => it should be one 'enable cri-o' but no fixing afterwards
enable clearlinux, disable iommu, drop containers-virt, dnnsec => just enable clearlinux
add kata, drop kata for docker => add kata for cri-o only
kubespray version bumps 2.9 and 2.10 => bump to 2.10

For future PRs, we also need to pay more attention to commit messages. "fix something" is not good unless the message also explains what was broken.

This change adds support to ClearLinux distribution using a Virtual Machine. It requires testing on Bare-Metal server.

This test.sh bash script tests multiple scenarios (different linux distros, container managers, container runtimes) using different screen sessions.

mythi

@electrocucaracha nice!

mythi reviewed Apr 8, 2019

View reviewed changes