-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup installation targets #35
Comments
@chivakker : FYI |
Is it possible to avoid compiling clang_sources, llvm and just use what's installed in the system? I would prefer not needing to compile a handful of packages if there's no actual need. Please fix. |
@chivakker : This change will be committed with Clang update. Please expect this In a couple of days. If there is a supported version of system LLVM and Clang available, IGC will dynamic link. |
I want to add an note here. If you do step 5 "sudo make install" on the README, this is what you will get as of today /usr/local/bin/GenX_IR Only selected files from ../igc-install/Release are copied over to /usr/local/ |
Thanks. I have tried 'make install' (thanks for adding it to readme) and indeed list of artifacts looks better. Still it requires review and cleanup. I would suggest to check whether you really need all of them. for example, there are few empty folders under I should note that IGC build instruction is confusing in a part of cmake configuration command: The confusing part is the requirement to have IGC_OPTION__OUTPUT_DIR variable specified while you already work in the user-created folder to store artifacts. Besides that the name you suggest is
|
Yeah, I'm (trying) to package this for Debian/Ubuntu, and wondering which headers could be dropped from the installed list, since the distro already has spirv-tools & -headers packaged, for instance.. |
Hello tjaalton, To package this run the following commands after running make: strip <Build_type>/*.so <Build_type>/Tools/GenX_IR You should see the following packages show up in your current directory: |
Also the package "intel-igc-opencl-devel_0.1-0_amd64.deb" does not include spirv-tools |
the resulting -opencl-devel surely has usr/include/igc/SPIRV/SPIRV-Tools/*, and it actually has spirv headers twice in the repo too, both under SPIRV-Tools/include and external/... IGC should be able to build with spirv-headers etc from the system |
Installation targets are all cleaned up with 630d16b. |
After 630d16b install tree looks as follows (common_clang files are from https://github.com/intel/opencl-clang install). I don't see intersections w/ other projects after that.
|
also available on igc_release_2019-03-12 |
After building IGC with the recommended steps:
I get the following layout:
This is most definitely not something I am expecting to see on Linux. Could you, please, change the layout to the Linux standard one (see https://cmake.org/cmake/help/v3.6/module/GNUInstallDirs.html):
bin
)lib
orlib64
orlib/<multiarch-tuple>
on Debian)Other questions/concerns:
clang
is the most obvious example,elf_packager
is the next suspectThe text was updated successfully, but these errors were encountered: