Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codeql: install libze to allow full analysis #1916

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

tkatila
Copy link
Contributor

@tkatila tkatila commented Dec 4, 2024

Noticed some time ago that codeql phase had this error in the logs:

cd cmd/gpu_levelzero; go build -tags ""
  # github.com/intel/intel-device-plugins-for-kubernetes/cmd/gpu_levelzero
  ze.c:19:10: fatal error: ze_api.h: No such file or directory
     19 | #include <ze_api.h>
        |          ^~~~~~~~~~
  compilation terminated.
  make: *** [Makefile:115: gpu_levelzero] Error 1
  2024/11/26 10:56:36 Running /usr/bin/make [make] failed, continuing anyway: exit status 2

This is an attempt to fix it.

@tkatila
Copy link
Contributor Author

tkatila commented Dec 4, 2024

Seems to fix it https://github.com/intel/intel-device-plugins-for-kubernetes/pull/1916/checks#step:6:229:

cd cmd/gpu_fakedev; go build -tags ""
cd cmd/gpu_levelzero; go build -tags ""
cd cmd/gpu_nfdhook; go build -tags ""

@tkatila tkatila marked this pull request as ready for review December 4, 2024 08:39
@tkatila tkatila requested review from bart0sh, kad and mythi as code owners December 4, 2024 08:39
Copy link
Contributor

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@mythi mythi merged commit fe08306 into intel:main Dec 4, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants