Misc fixes vol. 9/2024 #1835
Merged
Misc fixes vol. 9/2024 #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eero-t
reviewed
Sep 13, 2024
tkatila
force-pushed
the
misc-fixes-9-2024
branch
from
1186459
to
1f09721
Compare
In this case, the size doesn't change. The flags were working correctly before, afaik. This is mostly to avoid people wasting time with the same issues I had while working with the levelzero PR. |
Signed-off-by: Tuomas Katila <[email protected]>
Signed-off-by: Tuomas Katila <[email protected]>
tkatila
force-pushed
the
misc-fixes-9-2024
branch
from
1f09721
to
2d9ba91
Compare
mythi
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One is from static scan. The other is not really an issue but I noticed with asmflags, gcflags and ldflags that the flag handling could be better. This came up while working with the GPU levelzero PR.