Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fpga: add subsystem vendor & device fields to PCIDevice #1768

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

jstamel
Copy link
Contributor

@jstamel jstamel commented Jun 27, 2024

Adds subsystem vendor and device information to PCIDevice struct.

Useful for distinguishing different FPGA boards driven by the DFL driver, where vendor and device ID are the same (DFL PCI IDs).

@tkatila
Copy link
Contributor

tkatila commented Jul 2, 2024

Hi @jstamel and thanks for the PR. @bart0sh and/or @kad would you mind taking a look? From my point of view, the change is fine.

Copy link
Contributor

@tkatila tkatila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mythi
Copy link
Contributor

mythi commented Jul 22, 2024

@jstamel apologies for the silence

Useful for distinguishing different FPGA boards driven by the DFL driver, where vendor and device ID are the same

what is the gap you're observing with the plugin? AFAUI, we are not limiting the device selection based on these. See #621 and #625.

@jstamel
Copy link
Contributor Author

jstamel commented Jul 22, 2024

@mythi No problem and thanks for your comment.

I don't observe any gap regarding the device plugin functionality.
However, having that in place, provides more info about the underlying PCIDevice.

In my case, I need this because I work on a project for fetching FME sensors and I use your FPGA package as a library for instantiating available FMEs. What is more, my project follows the OPAE way of enumerating FPGA sensors for different FPGA HW types, that can be identified through the subsystem vendor and subsystem device IDs.

@mythi
Copy link
Contributor

mythi commented Jul 22, 2024

@jstamel makes sense, thanks for the quick response. I'll get this merged asap (CI needs fixing first)

@mythi mythi merged commit f75f8de into intel:main Jul 24, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants