Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhooks: make SGX mutator registration to follow other webhooks #1677

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Mar 4, 2024

Fixes: #1681

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 39.67%. Comparing base (ce5bfa4) to head (da81f1b).
Report is 2 commits behind head on main.

❗ Current head da81f1b differs from pull request most recent head cbaedda. Consider uploading reports for the commit cbaedda to get more accurate results

Files Patch % Lines
pkg/webhooks/sgx/sgx.go 0.00% 5 Missing ⚠️
cmd/operator/main.go 0.00% 1 Missing ⚠️
cmd/sgx_admissionwebhook/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1677      +/-   ##
==========================================
- Coverage   39.71%   39.67%   -0.04%     
==========================================
  Files          73       73              
  Lines        6521     6520       -1     
==========================================
- Hits         2590     2587       -3     
- Misses       3781     3782       +1     
- Partials      150      151       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mythi
Copy link
Contributor Author

mythi commented Mar 5, 2024

get #1681 fixed before merging

@mythi mythi requested a review from kad as a code owner March 7, 2024 11:46
@tkatila tkatila merged commit 7d00cf0 into intel:main Mar 8, 2024
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e-sgx: admissionwebhook tests are not run anymore
4 participants