Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements to "render-device.sh" GPU plugin helper script #1605

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Minor improvements to "render-device.sh" GPU plugin helper script #1605

merged 2 commits into from
Dec 4, 2023

Conversation

eero-t
Copy link
Contributor

@eero-t eero-t commented Dec 1, 2023

  • With no args, output info about devices available in container
  • Fix (harmless) shellcheck warnings

@eero-t
Fix (harmless) render-device.sh shellcheck warnings
4b39446 
Signed-off-by: Eero Tamminen <[email protected]>
@eero-t
List writable render devices with no render-device.sh args
3ade6d4 
To help debugging potential kubernetes device usage issues.

Signed-off-by: Eero Tamminen <[email protected]>
tkatila
tkatila approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@tkatila tkatila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

@tkatila tkatila merged commit 53372ed into intel:main Dec 4, 2023
75 checks passed
@eero-t eero-t deleted the render-devices branch December 12, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkatila tkatila tkatila approved these changes

@bart0sh bart0sh Awaiting requested review from bart0sh bart0sh is a code owner

@uniemimu uniemimu Awaiting requested review from uniemimu uniemimu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eero-t @tkatila