Change GPU plugin's behavior as Level zero's default hierarchy mode changed from composite to flat #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1601 +/- ##
==========================================
+ Coverage 51.79% 51.95% +0.15%
==========================================
Files 42 42
Lines 4873 4916 +43
==========================================
+ Hits 2524 2554 +30
- Misses 2204 2213 +9
- Partials 145 149 +4 ☔ View full report in Codecov by Sentry. |
eero-t
reviewed
Nov 20, 2023
tkatila
force-pushed
the
levelzero-hierarchy
branch
from
fd11435
to
4e81190
Compare
|
I added a picture for the "operation modes" to explain the three different modes. |
eero-t
reviewed
Nov 21, 2023
tkatila
force-pushed
the
levelzero-hierarchy
branch
from
4e81190
to
2ac7f65
Compare
eero-t
previously approved these changes
Nov 21, 2023
tkatila
force-pushed
the
levelzero-hierarchy
branch
from
2ac7f65
to
c50598b
Compare
eero-t
previously approved these changes
Nov 23, 2023
Signed-off-by: Tuomas Katila <[email protected]>
With tile requests, the level zero affinity mask now defaults to flat/combined mode. If ZE_FLAT_DEVICE_HIERARCHY is set to COMPOSITE in the Pod's specification, plugin will use the previous "x.y" format instead of the new "x" in the affinity mask. Signed-off-by: Tuomas Katila <[email protected]>
Split readme into smaller chunks, show only one "easy installation" and hide the rest. Add some notes about tile resources. Co-authored-by: Eero Tamminen <[email protected]> Signed-off-by: Tuomas Katila <[email protected]>
Signed-off-by: Tuomas Katila <[email protected]>
tkatila
force-pushed
the
levelzero-hierarchy
branch
from
c50598b
to
95b7230
Compare
|
Rebased. No functional changes. |
uniemimu
approved these changes
Dec 8, 2023
mythi
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "FLAT" affinity mask mode by default and do not set mask when there are only 1-tile GPUs.
Re-structure GPU's README:
-Simplify the main readme, move "nice to know" info to separate pages.
-Highlight only one installation method, rest are available on different page.