Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions (dlb demo and cert-manager, kind) #1543

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Update versions (dlb demo and cert-manager, kind) #1543

merged 2 commits into from
Nov 1, 2023

Conversation

hj-johannes-lee
Copy link
Contributor

No description provided.

@hj-johannes-lee hj-johannes-lee changed the title Makefile: update cert-manager to 1.13.0 Update versions (dlb demo and cert-manager) Sep 21, 2023
mythi
mythi previously approved these changes Sep 22, 2023
Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's OK, but getting pointless if we cannot update the kernel module too.

@mythi
Copy link
Contributor

mythi commented Sep 28, 2023

it's OK, but getting pointless if we cannot update the kernel module too.

@hj-johannes-lee have you tried with the corresponding driver in the kernel?

@mythi
Copy link
Contributor

mythi commented Oct 23, 2023

it's OK, but getting pointless if we cannot update the kernel module too.

@hj-johannes-lee have you tried with the corresponding driver in the kernel?

@hj-johannes-lee ping

@hj-johannes-lee
Copy link
Contributor Author

@mythi Sorry, I cannot build the driver in 6.5 and 6.6... I have no idea why.
What kernel version do you want me try?

@mythi
Copy link
Contributor

mythi commented Oct 24, 2023

The version is not that important but I'd go with whatever is the 6.x version they've tested. btw, 8.5.2 seems to be available already.

My original question/comment was that if we update to 8.5.1 we also need to check it with the same driver.

@hj-johannes-lee
Copy link
Contributor Author

I tested with 6.1.57 kernel version in SPR with 8.5.2 driver installed.

Signed-off-by: Hyeongju Johannes Lee <[email protected]>
Signed-off-by: Hyeongju Johannes Lee <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #1543 (33ed959) into main (4429fb4) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 33ed959 differs from pull request most recent head f55e432. Consider uploading reports for the commit f55e432 to get more accurate results

@@            Coverage Diff             @@
##             main    #1543      +/-   ##
==========================================
+ Coverage   49.50%   49.56%   +0.06%     
==========================================
  Files          42       42              
  Lines        4965     4965              
==========================================
+ Hits         2458     2461       +3     
+ Misses       2363     2361       -2     
+ Partials      144      143       -1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hj-johannes-lee hj-johannes-lee changed the title Update versions (dlb demo and cert-manager) Update versions (dlb demo and cert-manager, kind) Oct 31, 2023
@tkatila tkatila merged commit 2cdc45b into intel:main Nov 1, 2023
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants