Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpu_fakedev: better dra support #1518

Merged
merged 1 commit into from
Sep 8, 2023
Merged

gpu_fakedev: better dra support #1518

merged 1 commit into from
Sep 8, 2023

Conversation

uniemimu
Copy link
Contributor

This adds generation of the sys/bus folder files, so that dra can use the generated files to an extent.

@uniemimu
Copy link
Contributor Author

@eero-t to take this over

eero-t
eero-t reviewed Aug 31, 2023
View reviewed changes
cmd/gpu_fakedev/gpu_fakedev.go Outdated Show resolved Hide resolved
cmd/gpu_fakedev/gpu_fakedev.go Outdated Show resolved Hide resolved
cmd/gpu_fakedev/gpu_fakedev.go Outdated Show resolved Hide resolved
@uniemimu uniemimu requested a review from eero-t September 6, 2023 14:07
@uniemimu
gpu_fakedev: better dra support
7ed30b2 
This adds generation of the sys/bus folder files, so that dra
can use the generated files to an extent.

Signed-off-by: Ukri Niemimuukko <[email protected]>
@uniemimu uniemimu marked this pull request as ready for review September 7, 2023 13:45
@mythi
Copy link
Contributor

mythi commented Sep 7, 2023

offtopic: CODEOWNERS could be updated so that I'm not pulled for reviews :-)

eero-t
eero-t approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

When more than 2 items are joined, I would have preferred Sprintf() to be done separately from Join(), but otherwise this does increase readability (as all items are listed in the order they are in the resulting path).

@eero-t
Copy link
Contributor

eero-t commented Sep 8, 2023

@tkatila Do you also approve? (and could you update CODEOWNERS?)

@tkatila
Copy link
Contributor

tkatila commented Sep 8, 2023

@tkatila Do you also approve? (and could you update CODEOWNERS?)

I'll review shortly. And yes, I can update the CODEOWNERS.

tkatila
tkatila approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@tkatila tkatila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tkatila tkatila merged commit e0c0bd6 into intel:main Sep 8, 2023
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkatila tkatila tkatila approved these changes

@eero-t eero-t eero-t approved these changes

@mythi mythi Awaiting requested review from mythi

@bart0sh bart0sh Awaiting requested review from bart0sh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@uniemimu @mythi @eero-t @tkatila