e2e,gpu,fpga: divide single It() to have multiple layers #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hj-johannes-lee
requested review from
mythi,
bart0sh and
ozhuraki
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1491 +/- ##
==========================================
- Coverage 50.10% 50.04% -0.07%
==========================================
Files 43 43
Lines 4884 4884
==========================================
- Hits 2447 2444 -3
- Misses 2299 2301 +2
- Partials 138 139 +1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Structure is as follows:
Describe("FPGA plugin")
Context("af mode")
BeforeEach("run device plugin")
It("runs a pod requesting resources")
Context("region mode")
BeforeEach("run device plugin")
It("runs a pod requesting resources")
Signed-off-by: hj-johannes-lee <[email protected]>
Structure is as follows:
Describe("GPU plugin")
BeforeEach("deploys plugin")
Context("When device resources are available")
BeforeEach("checks if resources are available")
It("runs a pod requesting resources")
Signed-off-by: hj-johannes-lee <[email protected]>
mythi
approved these changes
Aug 15, 2023
|
@tkatila Sorry, Tuomas, that I did not wait your approval. If you find something else to be changed, let me fix it in another PR in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.