Link fixes, log fix and yaml updates #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1487 +/- ##
=======================================
Coverage 50.04% 50.04%
=======================================
Files 43 43
Lines 4884 4884
=======================================
Hits 2444 2444
Misses 2301 2301
Partials 139 139
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tkatila
force-pushed
the
link-fixes_log-fix_yaml-updates
branch
7 times, most recently
from
3afb2ad
to
34bf1ac
Compare
Signed-off-by: Tuomas Katila <[email protected]>
Signed-off-by: Tuomas Katila <[email protected]>
tkatila
force-pushed
the
link-fixes_log-fix_yaml-updates
branch
from
34bf1ac
to
26db596
Compare
tkatila
requested review from
mythi,
bart0sh,
ozhuraki and
hj-johannes-lee
as code owners
agree but we probably want a new issue to rework the part that checks when an update is needed |
True. I had forgotten about it. |
tkatila
force-pushed
the
link-fixes_log-fix_yaml-updates
branch
from
26db596
to
aa7c85a
Compare
Instead creating another overlay, copy the existing overlay and modify it. This helps with multi-level overlays with specific namespace selections. Co-authored-by: Mikko Ylinen <[email protected]> Signed-off-by: Tuomas Katila <[email protected]>
Signed-off-by: Tuomas Katila <[email protected]>
Signed-off-by: Tuomas Katila <[email protected]>
Signed-off-by: Tuomas Katila <[email protected]>
tkatila
force-pushed
the
link-fixes_log-fix_yaml-updates
branch
from
aa17a3b
to
e92b752
Compare
mythi
approved these changes
Aug 3, 2023
hj-johannes-lee
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started as a PR where I wanted to push some dangling fixes, but the yaml updates turned out to be more extensive than I anticipated.
Fixes #1446
Fixes #1449
Touches #1418