e2e: remove duplicate code of testing with operator #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hj-johannes-lee
requested review from
mythi,
bart0sh and
ozhuraki
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1472 +/- ##
=======================================
Coverage 50.04% 50.04%
=======================================
Files 43 43
Lines 4884 4884
=======================================
Hits 2444 2444
Misses 2301 2301
Partials 139 139 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mythi
reviewed
Jul 17, 2023
mythi
reviewed
Jul 18, 2023
mythi
reviewed
Jul 18, 2023
mythi
reviewed
Jul 19, 2023
move duplicate code for testing plugins using operator to operator module replace the code for deploying operator webhook in operator module with the code using utils.Kubectl to make simple for undeploying Signed-off-by: Hyeongju Johannes Lee <[email protected]>
mythi
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working for #1470, I noticed that we have go-cognit's min-complexity value is 31 and in many parts, it is already so close to the value that little addition of the code causes an error message from the linter check.
I do not know if we need to decide to ignore that check for e2e tests, but there is one thing we can improve already.
Tests with operator have duplicate code, and seems to be right decision to make a common function in utils.go.