e2e: gpu: add a basic tensorflow test #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkatila
force-pushed
the
e2e-gpu-tf
branch
3 times, most recently
from
b833633
to
504f09e
Compare
Codecov Report
@@ Coverage Diff @@
## main #1374 +/- ##
=======================================
Coverage 50.04% 50.04%
=======================================
Files 43 43
Lines 4884 4884
=======================================
Hits 2444 2444
Misses 2301 2301
Partials 139 139 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mythi
reviewed
Apr 12, 2023
|
This is stuck until I can get access to the bmaas machine to debug the failure. |
tkatila
force-pushed
the
e2e-gpu-tf
branch
2 times, most recently
from
883d612
to
b638697
Compare
tkatila
force-pushed
the
e2e-gpu-tf
branch
2 times, most recently
from
5eaf78d
to
7616ff0
Compare
tkatila
force-pushed
the
e2e-gpu-tf
branch
2 times, most recently
from
b61409e
to
ed09577
Compare
tkatila
requested review from
bart0sh,
ozhuraki and
hj-johannes-lee
as code owners
tkatila
force-pushed
the
e2e-gpu-tf
branch
3 times, most recently
from
1645929
to
cf90a6a
Compare
|
Please review. |
mythi
reviewed
Aug 17, 2023
test/e2e/gpu/gpu.go
Outdated
Comment on lines
137
to
145
| ginkgo.By("checking log output") | ||
| log, err := e2epod.GetPodLogs(ctx, f.ClientSet, f.Namespace.Name, tfPodName, containerName) | ||
|
|
||
| framework.Logf("logs: %s", log) | ||
|
|
||
| if err != nil { | ||
| framework.Failf("unable to get log from pod: %v", err) | ||
| } | ||
|
|
There was a problem hiding this comment.
@hj-johannes-lee can you comment on the logging part
There was a problem hiding this comment.
made a separate review because the previous line should be also changed IMO.
hj-johannes-lee
requested changes
Aug 22, 2023
test/e2e/gpu/gpu.go
Outdated
Comment on lines
135
to
143
| e2epod.NewPodClient(f).WaitForSuccess(ctx, tfPodName, 300*time.Second) | ||
|
|
||
| ginkgo.By("checking log output") | ||
| log, err := e2epod.GetPodLogs(ctx, f.ClientSet, f.Namespace.Name, tfPodName, containerName) | ||
|
|
||
| framework.Logf("logs: %s", log) | ||
|
|
||
| if err != nil { | ||
| framework.Failf("unable to get log from pod: %v", err) |
There was a problem hiding this comment.
err := e2epod.WaitForPodSuccessInNamespaceTimeout(ctx, f.ClientSet, tfPodName, f.Namespace.Name, 300*time.Second)
gomega.Expect(err).To(gomega.BeNil(), utils.GetPodLogs(ctx, f, tfPodName, containerName))
Signed-off-by: Tuomas Katila <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.