Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpu: add new nfd + monitoring + shared-dev deployment option #1292

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

tkatila
Copy link
Contributor

@tkatila tkatila commented Jan 2, 2023

Closes: #1283
Signed-off-by: Tuomas Katila [email protected]

@codecov-commenter
Copy link

Codecov Report

Merging #1292 (c40eca6) into main (3dfe545) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1292   +/-   ##
=======================================
  Coverage   50.61%   50.61%           
=======================================
  Files          43       43           
  Lines        4682     4682           
=======================================
  Hits         2370     2370           
  Misses       2176     2176           
  Partials      136      136           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mythi
Copy link
Contributor

mythi commented Jan 2, 2023

while we're at it, maybe fix #1283 in a separate commit?

@eero-t
Copy link
Contributor

eero-t commented Jan 2, 2023

/lgtm

CI checks seem just broken, as this does PR not touch anything related to the failing tests.

I don't see what's the problem with "iia", and "terrascan" & "sgx" fails to networking issues:

Run curl -sL "$(curl -sL https://api.github.com/repos/tenable/terrascan/releases/latest | grep -o -E "https://.+?_Linux_x86_64.tar.gz")" > terrascan.tar.gz
Error: Process completed with exit code 3.
 error creating build container: 2 errors occurred while pulling:
 * initializing source docker://192.168.33.10:5000/golang:1.19-bullseye: reading manifest 1.19-bullseye in 192.168.33.10:5000/golang: manifest unknown: manifest unknown
 * reading blob sha256:32de3c850997ce03b6ff4ae8fb00b34b9d7d7f9a35bfcdb8538e22cc7b77c29d: Get "https://cache-registry.caas.intel.com/v2/cache/library/golang/blobs/sha256:32de3c850997ce03b6ff4ae8fb00b34b9d7d7f9a35bfcdb8538e22cc7b77c29d": context deadline exceeded
[2/2] STEP 1/9: FROM gcr.io/distroless/static
make: *** [Makefile:213: intel-sgx-initcontainer] Error 125

@tkatila
Copy link
Contributor Author

tkatila commented Jan 2, 2023

while we're at it, maybe fix #1283 in a separate commit?

sure

Fixes intel#1283

Signed-off-by: Tuomas Katila <[email protected]>
@mythi
Copy link
Contributor

mythi commented Jan 3, 2023

while we're at it, maybe fix #1283 in a separate commit?

sure

Apologies, CI has faulty mirror config and currently registry.k8s.io images are not pulled. We will fix it.

@mythi
Copy link
Contributor

mythi commented Jan 3, 2023

/lgtm

CI checks seem just broken, as this does PR not touch anything related to the failing tests.

I don't see what's the problem with "iia", and "terrascan" & "sgx" fails to networking issues:

Right, they are not related to the PR content but random network glitches.

Run curl -sL "$(curl -sL https://api.github.com/repos/tenable/terrascan/releases/latest | grep -o -E "https://.+?_Linux_x86_64.tar.gz")" > terrascan.tar.gz
Error: Process completed with exit code 3.

this one has started to show up recently but I cannot think of the reason what might cause the flakiness.

@tkatila
Copy link
Contributor Author

tkatila commented Jan 4, 2023

Run curl -sL "$(curl -sL https://api.github.com/repos/tenable/terrascan/releases/latest | grep -o -E "https://.+?_Linux_x86_64.tar.gz")" > terrascan.tar.gz
Error: Process completed with exit code 3.

Return code 3 for curl is "malformed url". The inner curl can return empty when github.com starts rate limiting. It's actually fairly easy to trigger:

$ curl -sL "$(curl -sL https://api.github.com/repos/tenable/terrascan/releases/latest | grep -o -E "https://.+?_Linux_x86_64.tar.gz")" > terrascan.tar.gz
$ echo $?
3

@mythi
Copy link
Contributor

mythi commented Jan 4, 2023

Run curl -sL "$(curl -sL https://api.github.com/repos/tenable/terrascan/releases/latest | grep -o -E "https://.+?_Linux_x86_64.tar.gz")" > terrascan.tar.gz
Error: Process completed with exit code 3.

Return code 3 for curl is "malformed url". The inner curl can return empty when github.com starts rate limiting. It's actually fairly easy to trigger:

$ curl -sL "$(curl -sL https://api.github.com/repos/tenable/terrascan/releases/latest | grep -o -E "https://.+?_Linux_x86_64.tar.gz")" > terrascan.tar.gz
$ echo $?
3

Thanks for checking this! Perhaps we should switch to a URL we maintain ourselves?

https://github.com/tenable/terrascan/releases/download/v${TERRASCAN_VERSION}/terrascan_${TERRASCAN_VERSION}_Linux_x86_64.tar.gz

@mythi
Copy link
Contributor

mythi commented Jan 5, 2023

@uniemimu needs your approval

@tkatila
Copy link
Contributor Author

tkatila commented Jan 5, 2023

Thanks for checking this! Perhaps we should switch to a URL we maintain ourselves?

https://github.com/tenable/terrascan/releases/download/v${TERRASCAN_VERSION}/terrascan_${TERRASCAN_VERSION}_Linux_x86_64.tar.gz

I think it would help, but I'm not sure if it would completely get rid of the error. If the download link is also rate limited, the actual download could also break sometimes.

@uniemimu uniemimu merged commit f1af416 into intel:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update to NFD v0.12.0
5 participants