-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gpu: add new nfd + monitoring + shared-dev deployment option #1292
Conversation
Signed-off-by: Tuomas Katila <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1292 +/- ##
=======================================
Coverage 50.61% 50.61%
=======================================
Files 43 43
Lines 4682 4682
=======================================
Hits 2370 2370
Misses 2176 2176
Partials 136 136 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
while we're at it, maybe fix #1283 in a separate commit? |
/lgtm CI checks seem just broken, as this does PR not touch anything related to the failing tests. I don't see what's the problem with "iia", and "terrascan" & "sgx" fails to networking issues:
|
sure |
Fixes intel#1283 Signed-off-by: Tuomas Katila <[email protected]>
Apologies, CI has faulty mirror config and currently |
Right, they are not related to the PR content but random network glitches.
this one has started to show up recently but I cannot think of the reason what might cause the flakiness. |
Return code 3 for curl is "malformed url". The inner curl can return empty when github.com starts rate limiting. It's actually fairly easy to trigger:
|
Thanks for checking this! Perhaps we should switch to a URL we maintain ourselves?
|
@uniemimu needs your approval |
I think it would help, but I'm not sure if it would completely get rid of the error. If the download link is also rate limited, the actual download could also break sometimes. |
Closes: #1283
Signed-off-by: Tuomas Katila [email protected]