GPU nfdhook label split fix #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ukri Niemimuukko <[email protected]>
uniemimu
previously approved these changes
Dec 28, 2022
Codecov Report
@@ Coverage Diff @@
## main #1285 +/- ##
==========================================
+ Coverage 50.56% 50.61% +0.05%
==========================================
Files 41 43 +2
Lines 4634 4682 +48
==========================================
+ Hits 2343 2370 +27
- Misses 2157 2176 +19
- Partials 134 136 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
If k8s label starts or ends with a non alphanumeric char, it is ignored. This new split method cuts labels from the last alphanum characters and adds a control character to the beginning of the next chunk. The entity that uses these labels needs to then remove the control character before concatenating the chunks. Co-authored-by: Ukri Niemimuukko <[email protected]> Signed-off-by: Tuomas Katila <[email protected]>
tkatila
force-pushed
the
label-concat-fix
branch
from
d5d08e2
to
d90e35a
Compare
|
Renamed forbiddenChar as controlChar, no other changes vs. prev state. |
uniemimu
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k8s labels cannot start or end with a non alphanumeric character. This new split method splits the label with the last alphanumeric character (under 63 characters) and starts the next label with a control character (Z).