Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qat: add configuration of cfgServices to qat initcontainer #1234

Merged
merged 1 commit into from
Dec 13, 2022
Merged

qat: add configuration of cfgServices to qat initcontainer #1234

merged 1 commit into from
Dec 13, 2022

Conversation

hj-johannes-lee
Copy link
Contributor

@hj-johannes-lee hj-johannes-lee commented Nov 3, 2022 •
edited by mythi
Loading

Closes: #1142

Signed-off-by: Hyeongju Johannes Lee [email protected]

@hj-johannes-lee hj-johannes-lee marked this pull request as draft November 3, 2022 21:42
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022 •
edited
Loading

Codecov Report

Merging #1234 (abdd448) into main (b3f04dd) will decrease coverage by 0.22%.
The diff coverage is 3.22%.

❗ Current head abdd448 differs from pull request most recent head a6037ea. Consider uploading reports for the commit a6037ea to get more accurate results

@@            Coverage Diff             @@
##             main    #1234      +/-   ##
==========================================
- Coverage   50.78%   50.56%   -0.23%     
==========================================
  Files          41       41              
  Lines        4608     4634      +26     
==========================================
+ Hits         2340     2343       +3     
- Misses       2133     2157      +24     
+ Partials      135      134       -1
Impacted Files Coverage Δ
pkg/controllers/qat/controller.go 14.83% <0.00%> (-2.48%) ⬇️
cmd/gpu_nfdhook/labeler.go 85.65% <100.00%> (+1.26%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

mythi
mythi requested changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick review even if this is still in draft. In addition to the review comments, add documentation too.

demo/qat-init.sh Show resolved Hide resolved
pkg/apis/deviceplugin/v1/qatdeviceplugin_webhook.go Outdated Show resolved Hide resolved
test/e2e/qat/qatplugin_dpdk.go Outdated Show resolved Hide resolved
test/envtest/qatdeviceplugin_controller_test.go Outdated Show resolved Hide resolved
@hj-johannes-lee hj-johannes-lee marked this pull request as ready for review November 24, 2022 22:15
mythi
mythi reviewed Nov 29, 2022
View reviewed changes
cmd/qat_plugin/README.md Outdated Show resolved Hide resolved
mythi
mythi reviewed Nov 29, 2022
View reviewed changes
cmd/qat_plugin/README.md Outdated Show resolved Hide resolved
mythi
mythi requested changes Dec 5, 2022
View reviewed changes
cmd/qat_plugin/README.md Outdated Show resolved Hide resolved
cmd/qat_plugin/README.md Outdated Show resolved Hide resolved
deployments/qat_plugin/overlays/qat_initcontainer/qat.conf Show resolved Hide resolved
mythi
mythi requested changes Dec 10, 2022
View reviewed changes
pkg/apis/deviceplugin/v1/qatdeviceplugin_webhook.go Outdated Show resolved Hide resolved
pkg/controllers/qat/controller.go Outdated Show resolved Hide resolved
demo/qat-init.sh Outdated Show resolved Hide resolved
cmd/qat_plugin/README.md Outdated Show resolved Hide resolved
mythi
mythi reviewed Dec 12, 2022
View reviewed changes
cmd/qat_plugin/README.md Outdated Show resolved Hide resolved
deployments/operator/samples/deviceplugin_v1_qatdeviceplugin.yaml Outdated Show resolved Hide resolved
cmd/qat_plugin/README.md Outdated Show resolved Hide resolved
cmd/qat_plugin/README.md Outdated Show resolved Hide resolved
@mythi mythi merged commit 10a26b8 into intel:main Dec 13, 2022
@mythi mythi mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mythi mythi mythi approved these changes

@bart0sh bart0sh Awaiting requested review from bart0sh bart0sh is a code owner

@ozhuraki ozhuraki Awaiting requested review from ozhuraki ozhuraki is a code owner

@tkatila tkatila Awaiting requested review from tkatila tkatila is a code owner

@kad kad Awaiting requested review from kad kad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

configure QAT services via provisioningConfig
3 participants
@hj-johannes-lee @codecov-commenter @mythi