Merge pull request #1606 from mythi/PR-2023-057

codeql fixes
intel · Dec 4, 2023 · 1971717 · 1971717
2 parents 53372ed + 8f28a7b
commit 1971717
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/lib-codeql.yaml b/.github/workflows/lib-codeql.yaml
@@ -20,12 +20,16 @@ jobs:
     - name: Checkout repository
       uses: actions/checkout@v4
 
+    - uses: actions/setup-go@v4
+      with:
+        go-version-file: go.mod
+        check-latest: true
+
     - name: Initialize CodeQL
       uses: github/codeql-action/init@v2
       with:
         languages: 'go'
 
-    - uses: actions/setup-go@v4
     - name: Perform CodeQL Analysis
       uses: github/codeql-action/analyze@v2
       with:

diff --git a/pkg/fpga/dfl_linux.go b/pkg/fpga/dfl_linux.go
@@ -236,7 +236,7 @@ func (f *DflFME) GetPortsNum() int {
 	}
 
 	n, err := strconv.ParseUint(f.PortsNum, 10, 32)
-	if err != nil {
+	if err != nil || n >= math.MaxInt {
 		return -1
 	}
 

diff --git a/pkg/fpga/intel_fpga_linux.go b/pkg/fpga/intel_fpga_linux.go
@@ -241,7 +241,7 @@ func (f *IntelFpgaFME) GetPortsNum() int {
 	}
 
 	n, err := strconv.ParseUint(f.PortsNum, 10, 32)
-	if err != nil {
+	if err != nil || n >= math.MaxInt {
 		return -1
 	}