Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Polymer 3.0, and start move to LitElement + MWC #60

Merged
merged 8 commits into from
Sep 20, 2018

Conversation

kenchris
Copy link
Contributor

No description provided.

@kenchris
Copy link
Contributor Author

kenchris commented Sep 19, 2018

Some files are missing

image

If these files exist on some local hard drive - please commit :-) @kaixinjxq

@kenchris kenchris force-pushed the master branch 2 times, most recently from 3ce6c17 to 64f659f Compare September 19, 2018 15:14
@rakuco
Copy link

rakuco commented Sep 19, 2018

Some files are missing

They seem to have been overlooked in #35 and #39. @Honry, do you still have those around by any chance?

@kenchris kenchris force-pushed the master branch 6 times, most recently from d895200 to 329172a Compare September 19, 2018 22:16
@Honry
Copy link
Contributor

Honry commented Sep 20, 2018

Actually we didn't add these images at all, I thought @alexshalamov would help create them. Anyway, I will create a separate issue to track it. @alexshalamov, could you provide some guideline to create these images? Which tool were you using?

@Honry
Copy link
Contributor

Honry commented Sep 20, 2018

Issue link: #62

@rakuco
Copy link

rakuco commented Sep 20, 2018

While you're still at it: I guess you also need to drop all references to Bower from README.md, right?

@rakuco
Copy link

rakuco commented Sep 20, 2018

@kenchris has told me this is finally ready for merging, so let's go!

@rakuco rakuco merged commit d94de72 into intel:master Sep 20, 2018
rakuco pushed a commit that referenced this pull request Sep 20, 2018
import {LitElement, html} from '@polymer/lit-element';
import {installRouter} from '../node_modules/pwa-helpers/router.js';

const menuIcon = html`<svg height="24" viewBox="0 0 24 24" width="24"><path d="M3 18h18v-2H3v2zm0-5h18v-2H3v2zm0-7v2h18V6H3z"></path></svg>`;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be same color as the app header text color.

@xiuqijix xiuqijix mentioned this pull request Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants