Skip to content
This repository has been archived by the owner on Aug 25, 2024. It is now read-only.

arch: plugins: move plugins to DFFML org #1113

Open
yashlamba opened this issue May 13, 2021 · 0 comments
Open

arch: plugins: move plugins to DFFML org #1113

yashlamba opened this issue May 13, 2021 · 0 comments
Labels
housekeeping Restructuring, refactoring, removal of old functionality, etc. p0 Critical Priority

Comments

@yashlamba
Copy link
Contributor

yashlamba commented May 13, 2021

Some points discussed on 2021-05-13

Moving Forward:

  1. Make plugins list for 1st, 2nd and 3rd party plugins.
  2. Add them to a JSON file in dffml/dffml/plugins.json
    • Plugins by levels.
    • Link to repo.
    • Tutorials linked/fetch from the tutorials.
  3. Modify scripts in DFFML.
  4. Move scikit-learn to dffml-org (1st Party Plugin):
    • Write Generic CI for plugins.
      • Run tests on different OS.
      • lint.
      • Tutorials test.
      • Check collision/compatibility with 1st parties: This should be done in the core repo
        since it isn't something that breaks the plugin but the DFFML release process.
      • docstring build + tests.
  5. CI changes, DFFML:
    • Build docs for main repo.
    • Check and build docs for plugins (on commit not PR)
    • Tutorials test.
    • Compatibility check:
      • Run dffml service dev install / dffml install -level 1
        • If it works: Can be released.
  6. Difficult part - Tutorials!:
    • Simple way out is to list the dependencies for each tutorial and check them on there respective plugin repo.
    • Generate a tag from that workflow and put it on top of the tutorial.
    • pip install for each tutorial on top

Need to figure out:

  • On commit to dffml main repo: How to check whether tutorial would pass with current plugins. Plugins would essentially be green until they merge a commit after dffml.

Points to discuss:

  • Someway to build the docs in plugins and fetch in main repo when built.
@johnandersen777 johnandersen777 added housekeeping Restructuring, refactoring, removal of old functionality, etc. p0 Critical Priority labels May 13, 2021
@johnandersen777 johnandersen777 added this to the 0.4.1 Alpha Release milestone May 13, 2021
johnandersen777 pushed a commit that referenced this issue May 4, 2023
johnandersen777 pushed a commit that referenced this issue May 4, 2023
johnandersen777 pushed a commit that referenced this issue May 4, 2023
johnandersen777 pushed a commit that referenced this issue May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
housekeeping Restructuring, refactoring, removal of old functionality, etc. p0 Critical Priority
Projects
None yet
Development

No branches or pull requests

2 participants