feat(checkers): Add polarssl fedora contains patterns #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 9, 2022 04:17
terriko
requested changes
Jun 16, 2022
cve_bin_tool/checkers/expat.py
Outdated
| @@ -14,7 +14,7 @@ | |||
| http://www.cvedetails.com/vulnerability-feed.php?vendor_id=16735&product_id=0&version_id=0&orderby=3&cvssscoremin=0 | |||
|
|
|||
| Easiest way to check CVEs is currently the Changes.txt file. You can pinpoint the CVEs using grep as follows: | |||
| grep 'Release\|CVE' Changes.txt | |||
| grep 'Release\\|CVE' Changes.txt | |||
There was a problem hiding this comment.
Can you double check that the grep works as expected on the expat changes file after this change, and update it if it's no longer correct?
There was a problem hiding this comment.
Hello @terriko, Sorry, I probably changed this by a mistake. I'm going to revert this change.
There was a problem hiding this comment.
I probably changed this because backslash's parsing error on docstring, if it's parsed with __doc__ property the grep command would be correct.
Now I understand why docstring signed as regex before. I'm going to revert this too.
terriko
approved these changes
Jun 21, 2022
terriko
added
awaiting maintainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in this PR contains patterns for polarssl fedora added.
There is also a small modification on docstring.