Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for references in tuples #13

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Conversation

elbeno
Copy link
Contributor

@elbeno elbeno commented Sep 22, 2023

  • comparing tuples containing references
  • transforming tuples containing refererences

For some reason, `stdx::tuple` was making the non-standard choice about
comparing tuples of references. With this change, `tuple<int>` is comparable
with `tuple<int&>` in the obvious way.
The C++20-only tests can use the `add_tests` function in cmake.
When using `stdx::transform` on a tuple containing references, those references
would previously be decayed. Now they are preserved.
Copy link
Contributor

@lukevalenty lukevalenty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukevalenty lukevalenty merged commit 0540d81 into intel:main Sep 22, 2023
22 checks passed
@elbeno elbeno deleted the tuple-transform-refs branch October 9, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants