This repository has been archived by the owner on Aug 5, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 491
An improvement on regression and data reading #201
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ac85709
Modifications are made for improvements in non-standard images or lab…
tujie-jiangye b635748
Repair some of the bug
tujie-jiangye 3e3853c
Repair some of the bug
tujie-jiangye f7fe17a
delete some useful line
tujie-jiangye 455aa08
Update convert_imageset.cpp
tujie-jiangye abbc33f
Update data_layer.cpp
tujie-jiangye 347f1fc
Update convert_imageset_regression.cpp
tujie-jiangye 69fad13
Revision of code specification
tujie-jiangye File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please articulate why you made so many changes to this class? I don't think all of them are needed for this particular feature, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but these modifications do not conflict with the original Caffe. They can provide more powerful functions to meet our needs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about submit another PR for the enhancements you think useful? Let's just focus on the regression support in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your reminding. We have made changes according to your opinion and submitted PR again.The newly submitted web site is:#215. Here, I would like to explain to you our improvement. When we use the multi label regression problem of image data, I encounter the problem that LMDB database does not directly support. By modifying this class, that is, the LMDB data reading method, we solve this problem instead of converting it to H5Py. And in our testing process, we think that modification to this class is necessary.From this improvement, we find that the improvement is better than the traditional method and has a good performance on other similar problems, so we think this is an improvement on Intel coffee and we hope to get your approval.