Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DXGI header from GPGMM D3D12 header. #983

Merged
merged 1 commit into from
Feb 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions include/gpgmm_d3d12.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@

#ifndef GPGMM_D3D12_HEADERS_ALREADY_INCLUDED
# include <d3d12.h>
# include <dxgi1_4.h>
#endif // defined(GPGMM_D3D12_HEADERS_ALREADY_INCLUDED)

#ifndef GPGMM_WINDOWS_HEADERS_ALREADY_INCLUDED
Expand Down Expand Up @@ -690,12 +689,14 @@ namespace gpgmm::d3d12 {

/** \brief Create residency residency manager to manage memory.

Adapter requires DXGI 1.4 due to IDXGIAdapter3::QueryMemoryInfo. Use EnumAdapters to get the
IDXGIAdapter3.

@param descriptor A reference to RESIDENCY_MANAGER_DESC structure that describes the residency
manager.
@param pDevice device used by this allocator. Required parameter. Use CreateDevice get the
device.
@param pAdapter DXGI adapter used to create the device. Requires DXGI 1.4 due to
IDXGIAdapter3::QueryMemoryInfo. Use EnumAdapters to get the adapter.
@param pAdapter Adapter used to create the device.
@param[out] ppResidencyManagerOut Pointer to a memory block that receives a pointer to the
residency manager. Pass NULL to test if residency Manager creation would succeed, but not
actually create the residency Manager. If NULL is passed and residency manager creating
Expand Down Expand Up @@ -1449,14 +1450,12 @@ namespace gpgmm::d3d12 {

/** \brief Create a resource allocator with residency.

Residency requires at-least DXGI version 1.4.

@param allocatorDescriptor A reference to RESOURCE_ALLOCATOR_DESC structure that describes the
allocator.
@param pDevice device used by this allocator. Required parameter. Use CreateDevice get the
device.
@param pAdapter DXGI adapter used to create the device. Used to detect for additional device
capabilities (by GPU vendor). Optional parameter. Use EnumAdapters to get the adapter.
@param pAdapter adapter used to create the device. Used to detect for additional device
capabilities (by vendor). Optional parameter.
@param[out] ppResourceAllocatorOut Pointer to a memory block that receives a pointer to the
resource allocator. Pass NULL to test if allocator creation would succeed, but not actually
create the allocator.
Expand All @@ -1476,8 +1475,8 @@ namespace gpgmm::d3d12 {
allocator.
@param pDevice device used by this allocator. Required parameter. Use CreateDevice get the
device.
@param pAdapter DXGI adapter used to create the device. Used to detect for additional device
capabilities (by GPU vendor). Optional parameter. Use EnumAdapters to get the adapter.
@param pAdapter adapter used to create the device. Used to detect for additional device
capabilities (by vendor). Optional parameter.
@param pResidencyManager Pointer to a memory block that receives a pointer to the
residency manager.
@param[out] ppResourceAllocatorOut Pointer to a memory block that receives a pointer to the
Expand Down
1 change: 1 addition & 0 deletions src/fuzzers/D3D12Fuzzer.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

#include <gpgmm_d3d12.h>

#include <dxgi1_4.h>
#include <wrl.h>
#include <cstdint>

Expand Down
1 change: 1 addition & 0 deletions src/gpgmm/d3d12/CapsD3D12.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
#include "gpgmm/utils/Utils.h"
#include "gpgmm/utils/WindowsUtils.h"

#include <dxgi.h>
#include <memory>

namespace gpgmm::d3d12 {
Expand Down
1 change: 0 additions & 1 deletion src/gpgmm/d3d12/D3D12Platform.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#define SRC_GPGMM_D3D12_D3D12PLATFORM_H_

#include <d3d12.h>
#include <dxgi1_4.h>
#include <wrl.h>

// Keep backwards compatibility when using D3D12 feature flags that are only defined in a newer
Expand Down
1 change: 1 addition & 0 deletions src/gpgmm/d3d12/ResidencyManagerD3D12.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
#include "gpgmm/utils/EnumFlags.h"
#include "gpgmm/utils/LinkedList.h"

#include <dxgi1_4.h>
#include <gpgmm_d3d12.h>

#include <memory>
Expand Down
1 change: 1 addition & 0 deletions src/tests/D3D12Test.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
#include <string>
#include <vector>

#include <dxgi1_4.h>
#include <gpgmm_d3d12.h>

#include "gpgmm/d3d12/D3D12Platform.h"
Expand Down
Loading