Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MCDM/DXCore devices. #683

Open
mingmingtasd opened this issue Nov 2, 2022 · 4 comments
Open

Add support for MCDM/DXCore devices. #683

mingmingtasd opened this issue Nov 2, 2022 · 4 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@mingmingtasd
Copy link

We need DXCore to enumerate VPU device, so should we replace IDXGIAdapter with IDCoreAdapter? wdyt? @bjjones @bbernhar @junwei

@bjjones
Copy link
Contributor

bjjones commented Nov 4, 2022

In my brief research it looks like IDXCoreAdapter and IDXGIAdapter are not directly interchangeable. This would require us to use slightly different functions internally for residency management.

Any comments @bbernhar? Is VPU support in the scope of GPGMM? I'm not sure if there's another reason someone would use DXCore over DXGI.

@bbernhar
Copy link
Contributor

bbernhar commented Nov 4, 2022

I'm supportive and I think it fits with the overall architecture and direction of the project (DXCore backend). @bjjones Can I assign you to dig into this?

@bbernhar bbernhar changed the title Replace IDXGIAdapter with IDCoreAdapter in gpgmm_d3d12 Add support for MCDM/DXCore devices. Nov 4, 2022
@bbernhar bbernhar added the help wanted Extra attention is needed label Nov 4, 2022
@fujunwei
Copy link

fujunwei commented Nov 7, 2022

Thanks for support, I think DXGI still is our focus to integrate into Chromium for GPU device, VPU is a longer term plan to support as you changed the title of issue.

@mingmingtasd
Copy link
Author

Thanks for support, I think DXGI still is our focus to integrate into Chromium for GPU device, VPU is a longer term plan to support as you changed the title of issue.

Yes, agree. Just propose this here, we should consider supporting DXCore in the near future, maybe both support DXGI/DXCore currently by flag to select (for example, ENABLE_DXCORE= false by default) as onnx-runtime.

@bjjones bjjones self-assigned this Nov 7, 2022
bbernhar added a commit that referenced this issue Jan 31, 2024
Allows specifying another adapter type.

Issue: #683
bbernhar added a commit that referenced this issue Jan 31, 2024
Allows specifying another adapter type.

Issue: #683
bbernhar added a commit that referenced this issue Jan 31, 2024
Requires use of a segment agnostic type instead of a DXGI specific one.

Issue: #683
bbernhar added a commit that referenced this issue Jan 31, 2024
Requires use of a segment agnostic type instead of a DXGI specific one.

Issue: #683
bbernhar added a commit that referenced this issue Jan 31, 2024
Requires use of a segment agnostic type instead of a DXGI specific one.

Issue: #683
bbernhar added a commit that referenced this issue Jan 31, 2024
Requires use of a segment agnostic type instead of a DXGI specific one.

Issue: #683
bbernhar added a commit that referenced this issue Jan 31, 2024
bbernhar added a commit that referenced this issue Feb 1, 2024
bbernhar added a commit that referenced this issue Feb 1, 2024
bbernhar added a commit that referenced this issue Feb 1, 2024
bbernhar added a commit that referenced this issue Feb 2, 2024
Pulls out DXGI-specific logic from ResidencyManager to support non-DXGI adapters in the future.

Issue: #683
bbernhar added a commit that referenced this issue Feb 2, 2024
Pulls out DXGI-specific logic from ResidencyManager to support non-DXGI adapters in the future.

Issue: #683
bbernhar added a commit that referenced this issue Feb 2, 2024
Allows use of GPGMM D3D12 API without DXGI adapter.

Issue: #683
bbernhar added a commit that referenced this issue Feb 3, 2024
Allows use of GPGMM D3D12 API without DXGI adapter.

Issue: #683
bbernhar added a commit that referenced this issue Feb 12, 2024
In the future, DXGI will be conditionally built for projects that don't require DXGI.

Issue: #683
bbernhar added a commit that referenced this issue Feb 12, 2024
In the future, DXGI will be conditionally built for projects that don't require DXGI.

Issue: #683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants