Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding docker swarm support #591

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Conversation

antoniomtz
Copy link
Contributor

PR Checklist

  • [ x] Added label to the Pull Request for easier discoverability and search
  • [x ] Commit Message meets guidelines as indicated in the URL https://github.com/intel-retail/automated-self-checkout/blob/main/CONTRIBUTING.md
  • Every commit is a single defect fix and does not mix feature addition or changes
  • Unit Tests have been added for new changes
  • Updated Documentation as relevant to the changes
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with repository license and clearly outlined the added dependency.
  • PR change contains code related to security
  • PR introduces changes that breaks compatibility with other modules (If YES, please provide details below)

What are you changing?

  • Adding docker swarm support
  • Best practice is to not mount paths in the docker compose, since all nodes require to have the same path.

Issue this PR will close

close: #issue_number

Anything the reviewer should know when reviewing this PR?

Test Instructions if applicable

If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/automated-self-checkout )

Signed-off-by: Antonio Martinez <[email protected]>
@antoniomtz antoniomtz self-assigned this Jun 15, 2024
Signed-off-by: Antonio Martinez <[email protected]>
@antoniomtz antoniomtz added the enhancement New feature or request label Jun 17, 2024
@antoniomtz antoniomtz merged commit ffeebb2 into intel-retail:main Jun 18, 2024
6 checks passed
@antoniomtz antoniomtz deleted the swarm-support branch June 18, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants