Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert network back to localhost #579

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

brian-intel
Copy link
Contributor

@brian-intel brian-intel commented Jun 11, 2024

PR Checklist

  • Added label to the Pull Request for easier discoverability and search
  • Commit Message meets guidelines as indicated in the URL https://github.com/intel-retail/automated-self-checkout/blob/main/CONTRIBUTING.md
  • Every commit is a single defect fix and does not mix feature addition or changes
  • Unit Tests have been added for new changes
  • Updated Documentation as relevant to the changes
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with repository license and clearly outlined the added dependency.
  • PR change contains code related to security
  • PR introduces changes that breaks compatibility with other modules (If YES, please provide details below)

What are you changing?

Docker port needs to be linked to localhost since the other containers are using host network. This will possibly change in the future but for now works.

Issue this PR will close

close: #issue_number

Anything the reviewer should know when reviewing this PR?

Test Instructions if applicable

  • download PR
  • make run-demo
  • Should see demo window appear with video and object detection

If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/automated-self-checkout )

@brian-intel brian-intel added bug Something isn't working breaking 3.1 labels Jun 11, 2024
@brian-intel brian-intel merged commit 71221ee into intel-retail:main Jun 11, 2024
6 checks passed
@brian-intel brian-intel deleted the networkPort branch June 11, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1 breaking bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants