Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ms-catalog specific doc changes #571

Closed
wants to merge 22 commits into from

Conversation

NeethuES-intel
Copy link
Contributor

PR Checklist

  • Added label to the Pull Request for easier discoverability and search
  • Commit Message meets guidelines as indicated in the URL https://github.com/intel-retail/automated-self-checkout/blob/main/CONTRIBUTING.md
  • Every commit is a single defect fix and does not mix feature addition or changes
  • Unit Tests have been added for new changes
  • Updated Documentation as relevant to the changes
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with repository license and clearly outlined the added dependency.
  • PR change contains code related to security
  • PR introduces changes that breaks compatibility with other modules (If YES, please provide details below)

What are you changing?

Changes are specific to MS-catalog, as referenced here - https://github.com/intel-innersource/applications.services.esh.intel-edge-services-document

Issue this PR will close

close: #issue_number

Anything the reviewer should know when reviewing this PR?

Test Instructions if applicable

If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/automated-self-checkout )

@NeethuES-intel NeethuES-intel added documentation Improvements or additions to documentation enhancement New feature or request labels May 22, 2024
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if it matter for http_proxy setting or not but i think the port for that is 911 unless there is some change that i am not aware recently.

.github/workflows/builddocumentation.yml Outdated Show resolved Hide resolved
.github/workflows/publishtoaws.yml Outdated Show resolved Hide resolved
NeethuES-intel and others added 2 commits May 23, 2024 11:16
Co-authored-by: Jim Wang @ Intel <[email protected]>
Co-authored-by: Jim Wang @ Intel <[email protected]>
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -8,12 +8,12 @@ FROM intel/dlstreamer:2023.0.0-ubuntu22-gpu682-dpcpp as base
USER root

FROM base as build-default
COPY ./requirements.txt /requirements.txt
COPY src/requirements.txt /requirements.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this to work you'll need to modify the make file build command. Currently it uses "src/" for the build context when it should now use "."

https://github.com/NeethuES-intel/automated-self-checkout/blob/ms-catalog/Makefile#L34
https://github.com/NeethuES-intel/automated-self-checkout/blob/ms-catalog/Makefile#L37

@NeethuES-intel
Copy link
Contributor Author

Closing PR, as Edge Developer Toolbox doesn't support documentation + package creation for intel open source repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants