-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ms-catalog specific doc changes #571
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if it matter for http_proxy setting or not but i think the port for that is 911 unless there is some change that i am not aware recently.
Co-authored-by: Jim Wang @ Intel <[email protected]>
Co-authored-by: Jim Wang @ Intel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -8,12 +8,12 @@ FROM intel/dlstreamer:2023.0.0-ubuntu22-gpu682-dpcpp as base | |||
USER root | |||
|
|||
FROM base as build-default | |||
COPY ./requirements.txt /requirements.txt | |||
COPY src/requirements.txt /requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this to work you'll need to modify the make file build command. Currently it uses "src/" for the build context when it should now use "."
https://github.com/NeethuES-intel/automated-self-checkout/blob/ms-catalog/Makefile#L34
https://github.com/NeethuES-intel/automated-self-checkout/blob/ms-catalog/Makefile#L37
Closing PR, as Edge Developer Toolbox doesn't support documentation + package creation for intel open source repos. |
PR Checklist
What are you changing?
Changes are specific to MS-catalog, as referenced here - https://github.com/intel-innersource/applications.services.esh.intel-edge-services-document
Issue this PR will close
close: #issue_number
Anything the reviewer should know when reviewing this PR?
Test Instructions if applicable
If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/automated-self-checkout )